Skip to content

[5.0][api-digester] Don't report as API breaking when an ObjC protocol gets a new optional method #20838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2018
Merged

[5.0][api-digester] Don't report as API breaking when an ObjC protocol gets a new optional method #20838

merged 1 commit into from
Nov 29, 2018

Conversation

akyrtzi
Copy link
Contributor

@akyrtzi akyrtzi commented Nov 28, 2018

master: #20833

@akyrtzi akyrtzi requested a review from a team as a code owner November 28, 2018 21:08
@akyrtzi
Copy link
Contributor Author

akyrtzi commented Nov 28, 2018

@swift-ci Please test

@akyrtzi
Copy link
Contributor Author

akyrtzi commented Nov 29, 2018

This only touches the SDK checker, nothing else. It is needed for setting up CI. I checked with @najacque and she's fine with getting it in.

@akyrtzi akyrtzi merged commit 953d5e8 into swiftlang:swift-5.0-branch Nov 29, 2018
@akyrtzi akyrtzi deleted the 5.0-api-checker-optional-protocol branch November 29, 2018 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@akyrtzi