Improve attr_implements_fp.swift test. #20841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he expected behavior.
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test |
jrose-apple
reviewed
Nov 29, 2018
test/attr/attr_implements_fp.swift
Outdated
| @@ -1,6 +1,6 @@ | |||
| // RUN: %empty-directory(%t) | |||
| // RUN: echo 'main()' >%t/main.swift | |||
| // RUN: %target-swiftc_driver -o %t/a.out %s %t/main.swift -Xfrontend -enable-operator-designated-types -Xfrontend -solver-enable-operator-designated-types | |||
| // RUN: %target-swiftc_driver -Xfrontend -enable-operator-designated-types -Xfrontend -solver-enable-operator-designated-types -o %t/a.out %s %t/main.swift | |||
There was a problem hiding this comment.
If you're improving this test anyway, please use %target-build-swift instead of %target-swiftc_driver, which includes things like -module-cache-path.
There was a problem hiding this comment.
(Okay, that one specifically is in both, but there are some other options that are only in target-build-swift. And I should probably look into whether we still need both.)
|
Interesting. Swapping the position of the frontend arguments doesn't make any difference, but running tests with |
This reverts commit 0346fed. It turns out moving these arguments didn't result in this test passing. For some reason it's failing with `build-script -t`, but passing with `lit`.
This also builds `attr_implements_fp.swift`, and then uses it, so it also needed updating.
|
Oh actually it's |
|
@swift-ci Please smoke test |
stephentyrone
approved these changes
Nov 29, 2018
This was referenced Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several small changes: