Skip to content

[5.0][api-digester] Add '-protocol-requirement-white-list' option to the digester for when diagnosing API breakage in SDKs #20849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

akyrtzi
Copy link
Contributor

@akyrtzi akyrtzi commented Nov 29, 2018

This option access a file that lists protocol names that are 'whitelisted' for getting new protocol requirements. This allows the SDK checker to avoid flagging protocol method additions for protocols that we know are not intended for user classes to conform to.

master: #20843

…igester for when diagnosing API breakage in SDKs

This option access a file that lists protocol names that are 'whitelisted' for getting new protocol requirements.
This allows the SDK checker to avoid flagging protocol method additions for protocols that we know are not intended
for user classes to conform to.
Allows us to add informational comments in the text files that are used as inputs for the digester.
@akyrtzi akyrtzi requested a review from a team as a code owner November 29, 2018 01:11
@akyrtzi
Copy link
Contributor Author

akyrtzi commented Nov 29, 2018

@swift-ci Please test

@akyrtzi
Copy link
Contributor Author

akyrtzi commented Nov 29, 2018

This only touches the SDK checker, nothing else. It is needed for setting up CI. I checked with @najacque and she's fine with getting it in.

@akyrtzi akyrtzi merged commit c8da38f into swiftlang:swift-5.0-branch Nov 29, 2018
@akyrtzi akyrtzi deleted the 5.0-api-checker-protocol-whitelist branch November 29, 2018 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant