Use @_borrowed on a few declarations in the stdlib and overlays #20851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the stdlib's properties don't need @_borrowed because they're @inlinable, but I did find one place in an overlay where it's probably sensible to make the operation use generalized accessors even if they're resilient.
This is a performance hack: inlining a coroutine can promote heap allocations of the frame to stack allocations, which is valuable out of proportion to the normal weight. There are surely more principled ways of getting this effect, though.
|
@swift-ci Please test. |
AnnaZaks
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 5.0 version of #20415.
It is ABI-affecting. I would call it important for convergence because it affects the compilation of basically all code that is generic over collections.