Skip to content

Change rangeOfString(other) to range(of: other) in the docs #20860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

lucatorella
Copy link
Contributor

@lucatorella lucatorella commented Nov 29, 2018

In the NSStringAPI.swift there was still a reference to the old rangeOfString() method. This method was renamed to range(to:) (as part of the big renaming) so I fixed the documentation otherwise it can create some confusion 🙂

I fixed it also in swift-corelibs-foundation. PR is here swiftlang/swift-corelibs-foundation#1791

@lucatorella lucatorella changed the title Fix reference to range(of:) in the contains doc Change rangeOfString(other) to range(of: other) in the docs Nov 29, 2018
@gottesmm gottesmm requested a review from moiseev November 29, 2018 18:01
@gottesmm
Copy link
Contributor

Just running the tests.

@gottesmm
Copy link
Contributor

@swift-ci test

@CodaFi
Copy link
Contributor

CodaFi commented Nov 14, 2019

Sorry for leaving you hanging so long. I'm going to shepherd this patch in manually.

@lucatorella
Copy link
Contributor Author

@CodaFi thanks for getting this small fix in. I will close this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants