Skip to content

[5.0][stdlib][ABI] mark reduce(_:into:) __owned #20875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

airspeedswift
Copy link
Member

Pick of #20839 for 5.0. Given the goal of this method is to mutate the initial parameter, it should take it owned since the most common usage is to give up an initial value (like []) to it.

@airspeedswift airspeedswift requested a review from a team as a code owner November 29, 2018 19:43
Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@airspeedswift
Copy link
Member Author

@swift-ci please test

Copy link
Contributor

@AnnaZaks AnnaZaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and merging since it's an ABI change.

@AnnaZaks AnnaZaks merged commit 29f90a9 into swiftlang:swift-5.0-branch Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants