Add partial support for withDevice(.deviceType) {} #20897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
reviewed
Nov 30, 2018
pschuh
force-pushed
the
10
branch
2 times, most recently
from
9b669e3 to
cb428ef
Compare
rxwei
approved these changes
Nov 30, 2018
rxwei
reviewed
Nov 30, 2018
mhong
reviewed
Nov 30, 2018
| @_silgen_name("_swift_tfc_OpSetDeviceFromScope") | ||
| func _TFCOpSetDeviceFromScope(_ op: CTFEOp, _ status: CTFStatus) { | ||
| let context = _ExecutionContext.global | ||
| let device = context.sync { context.deviceScopes.last ?? .`default` }.opSetDeviceFromScope(op, status) |
There was a problem hiding this comment.
context.deviceScopes.last ?? .
default
Given we initialized deviceScopes with a root element (be it .cpu, or .default as i suggested above), should we instead assert that context.deviceScopes.last is never 'nil?
|
@swift-ci please test tensorflow |
rxwei
reviewed
Dec 1, 2018
rxwei
reviewed
Dec 1, 2018
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow macos |
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow |
…ger op dispatch. Unfortunately, this info gets ignored when any ops get extracted out into a graph, but hopefully static analysis of these calls could remove some of those differences.
|
@swift-ci please test tensorflow |
1 similar comment
|
@swift-ci please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a deviceScopes stack to CompilerRuntime to be consulted by the eager op dispatch.
Unfortunately, this info gets ignored when any ops get extracted out into a
graph, but hopefully static analysis of these calls could remove some of those differences.