Skip to content

[FrontendTool] [NFC] Reduce scope of FrontendObserver #20901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2018
Merged

[FrontendTool] [NFC] Reduce scope of FrontendObserver #20901

merged 1 commit into from
Nov 30, 2018

Conversation

harlanhaskins
Copy link
Contributor

These APIs weren't used.

@harlanhaskins
Copy link
Contributor Author

@swift-ci please smoke test

jrose-apple
jrose-apple approved these changes Nov 30, 2018
View reviewed changes
Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For anyone watching, there is still an Apple-internal client using parsedArgs, so we don't want to get rid of that one at this time.

@harlanhaskins harlanhaskins merged commit da3fe20 into swiftlang:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrose-apple jrose-apple jrose-apple approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harlanhaskins @jrose-apple