Skip to content

Generalize the JSON perf tests to Codable #20921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

Catfish-Man
Copy link
Contributor

No description provided.

@Catfish-Man
Copy link
Contributor Author

@swift-ci please benchmark

@swift-ci
Copy link
Contributor

Build comment file:

Build failed before running benchmark.


@Catfish-Man
Copy link
Contributor Author

@swift-ci please smoke benchmark

1 similar comment
@Catfish-Man
Copy link
Contributor Author

@swift-ci please smoke benchmark

@swift-ci
Copy link
Contributor

Build comment file:

Performance: -O

TEST MIN MAX MEAN MAX_RSS
Added
PlistPerfDecode 630 635 632
PlistPerfEncode 590 593 591

Performance: -Osize

TEST OLD NEW DELTA RATIO
Regression
CharacterLiteralsLarge 100 111 +11.0% 0.90x
Added
PlistPerfDecode 639 644 641
PlistPerfEncode 587 590 588

Performance: -Onone

TEST MIN MAX MEAN MAX_RSS
Added
PlistPerfDecode 708 712 710
PlistPerfEncode 615 620 617
Benchmark Check Report
⚠️Ⓜ️ PlistPerfDecode has very wide range of memory used between independent, repeated measurements.
PlistPerfDecode mem_pages [i1, i2]: min=[143, 151] 𝚫=8 R=[24, 0]
⚠️Ⓜ️ PlistPerfEncode has very wide range of memory used between independent, repeated measurements.
PlistPerfEncode mem_pages [i1, i2]: min=[1477, 1461] 𝚫=16 R=[50, 20]
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB
--------------

@Catfish-Man
Copy link
Contributor Author

@swift-ci please smoke test and merge

1 similar comment
@Catfish-Man
Copy link
Contributor Author

@swift-ci please smoke test and merge

@Catfish-Man
Copy link
Contributor Author

@swift-ci please smoke test and merge

2 similar comments
@Catfish-Man
Copy link
Contributor Author

@swift-ci please smoke test and merge

@Catfish-Man
Copy link
Contributor Author

@swift-ci please smoke test and merge

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test and merge

@Catfish-Man
Copy link
Contributor Author

Somehow my benchmark-only changes are causing 6 unexpected successes?

@Catfish-Man Catfish-Man force-pushed the codspeed branch 2 times, most recently from 45d8a0b to f30c33f Compare December 3, 2018 17:03
@Catfish-Man
Copy link
Contributor Author

@swift-ci please test and merge

2 similar comments
@Catfish-Man
Copy link
Contributor Author

@swift-ci please test and merge

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test and merge

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test and merge

1 similar comment
@Catfish-Man
Copy link
Contributor Author

@swift-ci please test and merge

@swift-ci swift-ci merged commit 4038e77 into swiftlang:master Dec 3, 2018
@Catfish-Man Catfish-Man deleted the codspeed branch December 3, 2018 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants