[TypeChecker] Fix a problem with rethrows classification. #20927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…function types. I have a follow-up change to correctly classify optional arguments, and with that fix applied we incorrectly emit rethrow diagnostics for 'nil' arguments passed in places where optional throwing functions are expected. This change ensures that we strip the throwing bit off of the nested function type so that we don't consider 'nil' arguments in these positions as potentially throwing functions.
We failed to properly classify arguments that are of optional function type, in this case leading to a verification failure due to the throws attribute on the apply expression not being set to some value. Fixes: SR-9102 / rdar://problem/45615204
|
@swift-ci Please smoke test |
rjmccall
approved these changes
Nov 30, 2018
|
@rjmccall It's to avoid inferring throwing-function types for nil-literal operands. In |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We failed to properly classify arguments that are of optional function
type, in this case leading to a verification failure due to the throws
attribute on the apply expression not being set to some value.
Fixes: SR-9102 / rdar://problem/45615204