Skip to content

[test] Remove overlays with extra NS stripping from the mock SDK #20954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

jrose-apple
Copy link
Contributor

There were only two tests still using them, and they weren't hard to migrate over to the normal mock SDK overlays.

There were only two tests still using them, and they weren't hard to
migrate over to the normal mock SDK overlays.
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.

@jrose-apple jrose-apple merged commit 0ba51b0 into swiftlang:master Dec 3, 2018
@jrose-apple jrose-apple deleted the you-dare-mock-me branch December 3, 2018 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants