Update Windows.md #20972
Merged
Update Windows.md #20972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the cmake configuration to actually reflect the current state of the world. This now builds against the MSVC built LLVM/clang and builds with clang-cl. This also enables building the test suite since that is starting to work on Windows. The MSVC commands are still out of date, but this is an overall improvement to the instructions. Since the primary work shifted towards Windows x86_64, we can use the prebuilt binaries for ICU from the ICU project as they provide Windows x86_64 builds.
|
@swift-ci please smoke test |
|
CC: @xiaobai |
|
Yeah the doc changes are clear to me and make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the cmake configuration to actually reflect the current state of the world. This now builds against the MSVC built LLVM/clang and builds with clang-cl. This also enables building the test suite since that is starting to work on Windows. The MSVC commands are still out of date, but this is an overall improvement to the instructions. Since the primary work shifted towards Windows x86_64, we can use the prebuilt binaries for ICU from the ICU project as they provide Windows x86_64 builds.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.