Skip to content

[5.0][CodeCompletion] Propagate completion status of parseGenericArguments() #20990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Dec 4, 2018

(Cherry-pick of #20960 for swift-5.0-branch. Not critical for convergence. Not ABI-affecting.)

Handle code-completion in generic argument list.

rdar://problem/39312854

To properly handle code-completion in generic argument list.

rdar://problem/39312854
(cherry picked from commit 5e69941)
@rintaro rintaro requested a review from a team December 4, 2018 02:41
@rintaro rintaro changed the title [CodeCompletion] Propagate completion status of parseGenericArguments() [5.0][CodeCompletion] Propagate completion status of parseGenericArguments() Dec 4, 2018
Copy link
Contributor

@akyrtzi akyrtzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding for merging after convergence

@akyrtzi
Copy link
Contributor

akyrtzi commented Dec 5, 2018

@swift-ci test and merge

@akyrtzi akyrtzi merged commit ceb847d into swiftlang:swift-5.0-branch Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants