[5.0][CodeCompletion] Eat identifier characters after CC position #20991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Text on editors (e.g. Xcode) may contain identifiers following to CC position which should be considered as "filtering text" for the code completion. For example, a user types '@A' the CC position is between '@' and 'a'. The user probably expects attributes starting with 'a'. Eat identifier characters after CC token in Lexer. By this change, for instance for '@<token>IB class', the parser now can detect this is a start of class declaration and emit class attributes completions. rdar://problem/46103294 (cherry picked from commit 56ce861)
akyrtzi
approved these changes
Dec 4, 2018
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Cherry-pick of #20959 for swift-5.0-branch, Not critical for convergence. Not ABI-affecting.)
Text in editors may contain identifier characters following to CC position which should be considered as "filtering text" for the code completion.
Eat identifier characters after CC token in Lexer. By this change, for instance, for
@<token>IB class, the parser now can detect this is a start of class declaration and emit class attributes for code completion.rdar://problem/46103294