Cache LLVM attributes for intrinsics #21006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking these up is slow because the attribute lists get rebuilt and reuniqued in the LLVM context each time. Saving them is a single pointer per IntrinsicInfo and IntrinsicInfos are already cached in each SILModule. This shaves about 4s off optimizing the standard library (72s out of a 3:00+ build), and probably has much less effect anywhere else. That is, it's not /really/ important after all, but it was an easy bit of the profile to hammer down.
At one point we were probably trying to avoid including llvm/IR/Intrinsics.h in Builtins.h but that ship has sailed. No functionality change.
Intrinsics never have custom function type ExtInfo anymore. (This used to be where the "noreturn" bit lived, but now that's represented by Swift.Never.) No functionality change.
|
@swift-ci Please test |
|
Turns out SIL optimizations call |
shajrawi
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking these up is slow because the attribute lists get rebuilt and reuniqued in the LLVM context each time. Saving them is a single pointer per IntrinsicInfo and IntrinsicInfos are already cached in each SILModule.
This shaves about 4s off optimizing the standard library (72s out of a 3:00+ build), and probably has much less effect anywhere else. That is, it's not really important after all, but it was an easy bit of the profile to hammer down.