[StdlibUnittest] Allow Interpreter to Expect Crashes #2101
Conversation
| @@ -0,0 +1,15 @@ | |||
| // RUN: %target-run-simple-swift -interpret | |||
There was a problem hiding this comment.
This substitution is not designed to accept parameters to the compiler. I'm not sure it even works the way you expect on OS X, but it definitely won't work on iOS.
I think the existing StdlibUnittest tests are sufficient, as long as they are run with the interpreter.
|
LGTM modulo the comment. |
|
@swift-ci Please test |
|
Actually I hadn't run the test suite normally when I pushed this so it crashes on every test. Can we cancel the build? |
|
I haven't pushed the fix; I'm running tests before I push it |
harlanhaskins
force-pushed
the
stdlibunittest-interpreter-skip-crashes
branch
from
c3b8895 to
7869605
Compare
harlanhaskins
force-pushed
the
stdlibunittest-interpreter-skip-crashes
branch
from
7869605 to
5d88887
Compare
|
@swift-ci please test |
|
@gribozavr I'm not sure what to make of the test failure... |
|
The many-inputs failure is an unrelated problem elsewhere. You can ignore it. |
|
It also exists on the master branch: https://ci.swift.org/job/oss-swift_tools-RA_stdlib-DA_test-simulator/935/console |
What's in this pull request?
Teach StdlibUnittest to run a sub-interpreter when run using the interpreter.
This allows interpreter-led tests to expect crashes and safely handle them.
Resolved bug number: (rdar://18080980)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.