Skip to content

Sourcekit/DocSupport: include fully annotated generic signatures for extension decls. #21013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2018

Conversation

nkcsgexi
Copy link
Contributor

@nkcsgexi nkcsgexi commented Dec 4, 2018

rdar://40906297
rdar://43820510

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Dec 4, 2018

@swift-ci please smoke test

@slavapestov
Copy link
Contributor

Why not include them for nominal types as well?

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Dec 4, 2018

because they're included in the fully annotated decls for nominal types.

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Dec 4, 2018

@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Dec 5, 2018

swiftlang/swift-cmark#8
@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Dec 5, 2018

Build failed
Swift Test OS X Platform
Git Sha - 0277f9a3b1bed1bc278b328cea5c13b60db8d2ba

@swift-ci
Copy link
Contributor

swift-ci commented Dec 5, 2018

Build failed
Swift Test Linux Platform
Git Sha - 0277f9a3b1bed1bc278b328cea5c13b60db8d2ba

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Dec 5, 2018

@swift-ci please smoke test

1 similar comment
@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Dec 5, 2018

@swift-ci please smoke test

…where clauses. rdar://43820510

This makes the printed requirements agree with separately reported generic parameters and requirement.
@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Dec 5, 2018

@swift-ci please smoke test

@nkcsgexi nkcsgexi merged commit 5da65ac into swiftlang:master Dec 6, 2018
@nkcsgexi nkcsgexi deleted the doc-support branch December 6, 2018 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants