Skip to content

Future-proof the ARM64 ABI by not reserving the entire top byte. #21015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rjmccall
Copy link
Contributor

@rjmccall rjmccall commented Dec 4, 2018

Targets that want to use armv8.5a memory tagging will need this. Hopefully nobody comes up with a brilliant reason they need to use anything else.

This is ABI-affecting but is unlikely to cause serious convergence problems because it only affects a small set of code-emission situations.

rdar://46465903

Targets that want to use armv8.5a memory tagging will need this.
Hopefully nobody comes up with a brilliant reason they need to use
anything else.
@rjmccall rjmccall requested a review from a team as a code owner December 4, 2018 21:29
@rjmccall rjmccall requested a review from jckarter December 4, 2018 21:29
@rjmccall
Copy link
Contributor Author

rjmccall commented Dec 4, 2018

@swift-ci Please test.

Copy link
Contributor

@bob-wilson bob-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnnaZaks AnnaZaks merged commit 5a98648 into swiftlang:swift-5.0-branch Dec 5, 2018
@rjmccall rjmccall deleted the arm64-tbi-future-proofing-5.0 branch December 5, 2018 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants