Skip to content

Remove \brief commands from doxygen comments. #21017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

adrian-prantl
Copy link
Contributor

[This is analogous to LLVM r331272 and CFE r331834]

We've been running doxygen with the autobrief option for a couple of
years now. This makes the \brief markers into our comments
redundant. Since they are a visual distraction and we don't want to
encourage more \brief markers in new code either, this patch removes
them all.

Patch produced by

  for i in $(git grep -l '\\brief'); do perl -pi -e 's/\\brief //g' $i & done

Copy link
Contributor

@jckarter jckarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great to me!

@jckarter
Copy link
Contributor

jckarter commented Dec 4, 2018

@swift-ci Please test

@jrose-apple
Copy link
Contributor

Next up on the chopping block: the really old style of "FooMethod - Does the foo thing."

@adrian-prantl
Copy link
Contributor Author

@swift-ci test

1 similar comment
@adrian-prantl
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented Dec 4, 2018

Build failed
Swift Test Linux Platform
Git Sha - 5555e2bcac2ee918936154ea79b77d4306323cdd

@swift-ci
Copy link
Contributor

swift-ci commented Dec 4, 2018

Build failed
Swift Test OS X Platform
Git Sha - 5555e2bcac2ee918936154ea79b77d4306323cdd

We've been running doxygen with the autobrief option for a couple of
years now. This makes the \brief markers into our comments
redundant. Since they are a visual distraction and we don't want to
encourage more \brief markers in new code either, this patch removes
them all.

Patch produced by

      for i in $(git grep -l '\\brief'); do perl -pi -e 's/\\brief //g' $i & done
@adrian-prantl
Copy link
Contributor Author

@swift-ci test and merge

@adrian-prantl
Copy link
Contributor Author

@swift-ci test and merge

1 similar comment
@adrian-prantl
Copy link
Contributor Author

@swift-ci test and merge

@adrian-prantl
Copy link
Contributor Author

That test failure looks unrelated.

@swift-ci smoke test

@adrian-prantl adrian-prantl merged commit bf2a471 into swiftlang:master Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants