IRGen: gatherbits - extend the bits before we shift left #21022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SR-9335 rdar://46264497
|
@swift-ci Please smoke test |
jrose-apple
reviewed
Dec 5, 2018
| // RUN: %empty-directory(%t) | ||
|
|
||
| // RUN: %target-build-swift -o %t/a.out %s | ||
| // RUN: %target-run %t/a.out 2>&1 |
There was a problem hiding this comment.
Nitpick: This should use %target-run-simple-swift, which is a slightly more flexible substitution. There's also no need to pipe 2>&1.
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
jrose-apple
reviewed
Dec 5, 2018
| @@ -1,7 +1,6 @@ | |||
| // RUN: %empty-directory(%t) | |||
|
|
|||
| // RUN: %target-build-swift -o %t/a.out %s | |||
| // RUN: %target-run %t/a.out 2>&1 | |||
| // RUN: %target-run-simple-swift %s | |||
There was a problem hiding this comment.
Ah, sorry, this substitution has the %s in it already. You also don't need the %empty-directory in this case.
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SR-9335
rdar://46264497