IDE: preserve the environment in the triple #21027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
I think you might as well do this whenever the environment is non-empty. That'll help with the "simulator" environment they're slowly bringing up for iOS simulator triples. |
Adjust the triple manipulation to preserve the environment. This is particularly important for android which is an environment for Linux, and Windows, where we support specific environments only.
compnerd
force-pushed
the
save-the-environment
branch
from
fcccb90 to
7f6a333
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
Build failed |
|
@swift-ci please test macOS platform |
|
Build failed |
|
Looks like this failure is also happening on master. |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the triple manipulation to preserve the environment in the case
of non-Darwin targets. This is particularly important for android which
is an environment for Linux, and Windows, where we support specific
environments only.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.