[CSDiagnostics] Diagnose invalid optional unwrap via fixes #21043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the base type is not optional, trying to unwrap it is incorrect. Introduce a fix to make it look like base was an optional type which leads solver to move forward towards possible solution.
Detect and fix situations when (force) unwrap is used on a non-optional type, this helps to diagnose invalid unwraps precisely and provide fix-its. Resolves: [SR-8977](https://bugs.swift.org/browse/SR-8977) Resolves: rdar://problem/45218255
|
@swift-ci please test |
|
Build failed |
|
Test failure is unrelated to diagnostics but let's re-try, maybe the fix already went in... |
|
@swift-ci please test macOS platform |
|
Addressed by #21047 |
rudkx
approved these changes
Dec 5, 2018
jrose-apple
reviewed
Dec 5, 2018
This was referenced Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect and fix situations when (force) unwrap is used on
a non-optional type, this helps to diagnose invalid unwraps
precisely and provide fix-its.
Resolves: SR-8977
Resolves: rdar://problem/45218255