[test] Add missing "executable_test" requirements #21050
Conversation
| @@ -1,5 +1,8 @@ | |||
| // RUN: %target-typecheck-verify-swift -swift-version 4.2 | |||
| // RUN: %target-run-simple-swift -swift-version 4.2 %s | %FileCheck %s | |||
| // RUN: %target-build-swift -swift-version 4.2 %s -o %t | |||
| // RUN: %target-run %t | %FileCheck %s | |||
There was a problem hiding this comment.
@brentdax I tweaked this as well because %target-run-simple-swift passes its arguments to the executable, not to the compiler. At the moment the test suite's still being run in pre-Swift-5 mode anyway so it didn't change anything.
There was a problem hiding this comment.
@brentdax Also it might be good to create a new executable test for this in test/Interpreter, so that test/Parse remains non-executable, even if it requires duplicating some test code.
There was a problem hiding this comment.
I'm fine with the test being moved or split—I didn't realize we were trying to keep that directory non-executable. Do you want me to do that?
|
@swift-ci Please smoke test |
jrose-apple
force-pushed
the
executable-expectations
branch
from
0be6996 to
79dfb8e
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
These keep the tests from failing when running for device targets with
--param swift_test_mode=only_non_executable.