Skip to content

[5.0] IRGen: gatherbits - extend the bits before we shift left #21054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 6, 2018
Merged

[5.0] IRGen: gatherbits - extend the bits before we shift left #21054

merged 2 commits into from
Dec 6, 2018

Conversation

aschwaighofer
Copy link
Contributor

  • No ABI impact
  • Correctness (of enums)

rdar://46264497

@aschwaighofer
[5.0] IRGen: gatherbits - extend the bits before we shift left
f8ffbc5 
* No ABI impact
* Correctness (of enums)

rdar://46264497
@aschwaighofer aschwaighofer requested a review from a team as a code owner December 5, 2018 20:14
@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@aschwaighofer
Fix IRGen test case
ab2d143 
Don't look for the function attribute reference
@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Dec 6, 2018

Build failed
Swift Test Linux Platform
Git Sha - f8ffbc5

@swift-ci
Copy link
Contributor

swift-ci commented Dec 6, 2018

Build failed
Swift Test OS X Platform
Git Sha - f8ffbc5

@eeckstein
Copy link
Contributor

@swift-ci test macOS

eeckstein
eeckstein approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@eeckstein eeckstein merged commit f6437f2 into swiftlang:swift-5.0-branch Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeckstein eeckstein eeckstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aschwaighofer @swift-ci @eeckstein