[Import as member] First draft of renaming CG APIs #2107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
| # CGBitmapContext | ||
| # FIXME: below doesn't work | ||
| - Name: CGBitmapContextCreateImage | ||
| SwiftName: CGContextRef.makeImageFromBitmap(self:) |
There was a problem hiding this comment.
This probably isn't so important, but what's the reason for these all having "Ref" on them? Shouldn't we prefer the non-Ref names?
There was a problem hiding this comment.
It's due to a limitation in the ClangImporter, where name lookup is done on C names rather than Swift type names. The C name CGContext turns out to be a forward declaration only, and we can't import those as decl contexts.
I've asked @DougGregor if we should use Swift lookup instead.
Several CG APIs are meant to be imported as nonswift, so mark them so in our API notes.
This includes several large manual renaming of CG APIs where we want different results than what the inference system produces.
|
@swift-ci please test |
|
@swift-ci please test |
|
Reverted in #2110 because this broke the build. |
|
That build failure might be another "delete the module cache" problem like this one earlier today: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.