Skip to content

[CMake] Move cross-platform dispatch/blocks support to the tools level, in preparation for the syntax parser library #21075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2018

Conversation

akyrtzi
Copy link
Contributor

@akyrtzi akyrtzi commented Dec 6, 2018

Move the cross-platform dispatch/blocks support from sourcekitd to a level that other tools can use it. This is in preparation for the syntax parser library (https://forums.swift.org/t/speeding-up-swiftsyntax-by-using-the-parser-directly/18493) that will have blocks in its C API.

…l, in preparation for the syntax parser library
@akyrtzi akyrtzi requested a review from compnerd December 6, 2018 06:49
@akyrtzi
Copy link
Contributor Author

akyrtzi commented Dec 6, 2018

@swift-ci smoke test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. Personally, I would have preferred to have seen this as two commits: one that does a move of the existing content without any changes, and a second follow up which sets up the syntax parser library defaults.

@akyrtzi akyrtzi merged commit 9694851 into swiftlang:master Dec 6, 2018
@akyrtzi akyrtzi deleted the syntax-parser-cmake-prep branch December 6, 2018 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants