[5.0] String performance and code size improvements #21081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compare small strings in-register when they store ASCII (and thus NFC) contents.
Add in a fast-path for Strings created from Substring which covers the entire String. Put String-from-Substring behind a non-inlinable resilience barrier for future flexibility.
|
@apple/swift5-branch-managers we will want this for the release, but no rush.
ConvergenceThis adds nice performance and code size improvements, but is not necessary for convergence. ABI impactNone/Additive |
|
@swift-ci please test |
airspeedswift
approved these changes
Dec 6, 2018
|
Build failed |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick PR of #21024 and #21072, which bring performance and code size improvements.