Skip to content

[ownership] init_existential_ref is not forwarding: it should only tr… #21093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Dec 6, 2018

…affic in owned values.

This was true already on the ValueOwnership side. This was exposed by a test in
test/Interpreter/FunctionConversions.swift where we emitted SIL like the test
for this PR.

rdar://43398898

…affic in owned values.

This was true already on the ValueOwnership side. This was exposed by a test in
test/Interpreter/FunctionConversions.swift where we emitted SIL like the test
for this PR.

rdar://43398898
@gottesmm gottesmm requested a review from atrick December 6, 2018 21:08
@gottesmm
Copy link
Contributor Author

gottesmm commented Dec 6, 2018

@swift-ci smoke test

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@gottesmm
Copy link
Contributor Author

gottesmm commented Dec 6, 2018

This hit an ordering problem with #21099. I need to get that in first.

@gottesmm
Copy link
Contributor Author

I fixed this in a different PR.

@gottesmm gottesmm closed this Mar 13, 2019
@gottesmm gottesmm deleted the pr-d5e71d0cb852c7306835559b5f7d4f8de1896d44 branch March 13, 2019 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants