Sema: Fix failure to emit a diagnostic when a protocol witness is being validated already #21134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DougGregor This fixes a regression from the fix for rdar://problem/37255982. Please review |
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
…ng validated already Validating a declaration can trigger conformance checking. If the conformance checker comes across the same declaration as a candidate witness, it would fail to emit a diagnostic. As a result we would then go onto SILGen, which would crash while emitting a witness table with a missing entry. Fixes <rdar://problem/45151902>.
slavapestov
force-pushed
the
circular-conformance-check-fail
branch
from
06603a8 to
8c65333
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
1 similar comment
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validating a declaration can trigger conformance checking. If the conformance checker
comes across the same declaration as a candidate witness, it would fail to emit a
diagnostic. As a result we would then go onto SILGen, which would crash while emitting
a witness table with a missing entry.
Fixes rdar://problem/45151902.