[benchmark] Fix lit test for Benchmark_Driver #21150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@eeckstein @aschwaighofer I'm gonna merge this fix. Let's see if any of the verifications builds fail when you arrive to work this morning 😬🤨 |
|
Somehow I didn't commit the removal of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves SR-9442.
Test expects to see
Ackermannin the output, but if the check passes without any issues, which it now should, the test failed.The fix was to add
--verboseflag, to always seeAckermannin the DEBUG output, as the point of this integration test is just to see the python script doesn't crash when invoking the driver.