Runtime: Fix metatype to mangling of function with single tuple-typed argument [5.0] #21156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While declaration mangling now does the right thing for parameter lists, the function type mangling unfortunately still models the parameter list as a single tuple node. Change the runtime's behavior to match the AST mangler, which wraps a single tuple-typed parameter in a tuple node, so that we can produce different mangling trees for function types taking multiple arguments versus a single tuple argument.
…ngle tuple argument
|
@swift-ci Please test |
slavapestov
changed the title
AnnaZaks
approved these changes
Dec 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes converting a metatype to a readable string when the metatype is for a function type with a single tuple type argument.
Unfortunately the mangling for function types was never properly updated for the new post-SE-0110 representation, so there's a hack in ASTMangler. Preserve the hack on the runtime side.
Fixes https://bugs.swift.org/browse/SR-8235, rdar://problem/42134697.