Skip to content

[semantic-arc-opts] Abstract out the check if a value is consumed int… #21164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

…o a utility called isConsumed().

I am doing this for two reasons:

  1. I want to use this in a different optimization where we optimize load [copy]
    => load_borrow.
  2. This will ensure that if/when the ownership APIs change to use isConsume/etc
    instead of the current operand ownership map, the optimization will be easy to
    update.

…o a utility called isConsumed().

I am doing this for two reasons:

1. I want to use this in a different optimization where we optimize load [copy]
=> load_borrow.
2. This will ensure that if/when the ownership APIs change to use isConsume/etc
instead of the current operand ownership map, the optimization will be easy to
update.
@gottesmm
Copy link
Contributor Author

This is just a manual refactor. I am going to use this in a follow on commit.

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test and merge

@gottesmm gottesmm requested a review from atrick December 10, 2018 07:47
@swift-ci swift-ci merged commit 318297c into swiftlang:master Dec 10, 2018
@gottesmm gottesmm deleted the pr-e4e8e0af3f79e007b5d817abeccf02e6e8de7c99 branch December 10, 2018 10:03
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants