[5.0] [Driver] Don't suggest using the "major version" for -swift-version #21169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wiftlang#20563) This was a nice feature when people said "-swift-version 3.1"... up until we got "-swift-version 4.2" as an actual valid version. Just drop the special case. https://bugs.swift.org/browse/SR-8850 (cherry picked from commit 00ed3e1)
|
@swift-ci Please test |
AnnaZaks
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Passing an unsupported number to
-swift-versionproduces a diagnostic that looks like this when the number has a minor component:This was a nice feature when people said
-swift-version 4.1...up until we got-swift-version 4.2as an actual valid version. This change just drops the special case.Scope: Diagnosing an invalid argument only.
Issue: SR-8850 / rdar://problem/44797691
Risk: Very low. No valid compile can be depending on this, since it produces an error.
Testing: Passed regression tests.
Reviewed by: @davidungar