Skip to content

[5.0][Stdlib] Rename AnyKeyPath's ObjC name and _VaListBuilder to avoid conflicts with older stdlibs. #21173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Dec 10, 2018

Cherry-pick #21127 to swift-5.0-branch.

rdar://problem/46546165

@mikeash mikeash requested a review from a team as a code owner December 10, 2018 17:56
@mikeash
Copy link
Contributor Author

mikeash commented Dec 10, 2018

@swift-ci please test

@mikeash
Copy link
Contributor Author

mikeash commented Dec 10, 2018

@apple/swift5-branch-managers Not critical for convergence and does not affect ABI.

Copy link
Contributor

@bob-wilson bob-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this to be sure we can support runtime coexistence with older versions of Swift. Mike, can you please merge the master PR a day or two before this one? Just in case that exposes any issues....

@mikeash
Copy link
Contributor Author

mikeash commented Dec 10, 2018

Ok. I merged the master PR and I’ll sit on this one for a bit.

@bob-wilson
Copy link
Contributor

I haven't heard about any fallout on master, so I'll go ahead and merge this now.

@bob-wilson bob-wilson merged commit 06df713 into swiftlang:swift-5.0-branch Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants