[5.0] Driver: correct the registrar extension #21180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The object file extension on Windows is `.obj` rather than `.o`. Ensure that we get the extension correct when compiling for Windows. Furthermore, ensure that we install with the correct extension when installing a cross-compiled image. As we may be using the homegrown cross-compilation system, we must explicitly handle the extension ourselves. This allows nearly a 100 additional tests to pass on Windows.
|
@apple/swift5-branch-managers (@tkremenek) ... this is a low risk cherry-pick from master. It impacts only the windows target, fixing the file extension for image registration object when cross-compiling and running the driver for a windows target. There is no impact to the linux or Darwin targets. |
|
@swift-ci please test |
|
@bob-wilson/@tkremenek - could you merge this please? |
compnerd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The object file extension on Windows is
.objrather than.o. Ensurethat we get the extension correct when compiling for Windows.
Furthermore, ensure that we install with the correct extension when
installing a cross-compiled image. As we may be using the homegrown
cross-compilation system, we must explicitly handle the extension
ourselves. This allows nearly a 100 additional tests to pass on
Windows.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.