Skip to content

uniquely allocate AutoDiffParameterIndices and AutoDiffAssociatedFunctionIdentifier #21193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 11, 2018
Merged

uniquely allocate AutoDiffParameterIndices and AutoDiffAssociatedFunctionIdentifier #21193

merged 5 commits into from
Dec 11, 2018

Conversation

marcrasi
Copy link

@marcrasi marcrasi force-pushed the unique-ad-structures branch from cea1b5e to d9102e6 Compare December 10, 2018 23:54
@marcrasi marcrasi requested a review from rxwei December 10, 2018 23:54
@marcrasi
Copy link
Author

@swift-ci please test tensorflow

@marcrasi
Copy link
Author

@rxwei, I have deleted isMethodFlag from the indices.

@swift-ci please test tensorflow

@marcrasi
Copy link
Author

@swift-ci please test tensorflow

rxwei
rxwei approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@rxwei rxwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

lib/AST/ASTContext.cpp Outdated

AutoDiffAssociatedFunctionIdentifier *
AutoDiffAssociatedFunctionIdentifier::get(
AutoDiffAssociatedFunctionKind kind,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent by 4.

@rxwei
Copy link
Contributor

rxwei commented Dec 11, 2018

Additional comments (which need not be addressed in the short term):

  • It seems that this data structure can also be used for SIL for consistency and efficiency, especially when it no longer carries the isMethod flag.
  • Since we need to represent result selection in SIL functions using the same bit vector representation, would it make sense to rename this to AutoDiffIndexSet or AutoDiffIndexSelection?

@marcrasi marcrasi force-pushed the unique-ad-structures branch from 1bba497 to f57a572 Compare December 11, 2018 18:29
@marcrasi
Copy link
Author

@swift-ci please test tensorflow

1 similar comment
@marcrasi
Copy link
Author

@swift-ci please test tensorflow

@marcrasi
Copy link
Author

@swift-ci please test tensorflow

3 similar comments
@marcrasi
Copy link
Author

@swift-ci please test tensorflow

@marcrasi
Copy link
Author

@swift-ci please test tensorflow

@marcrasi
Copy link
Author

@swift-ci please test tensorflow

@marcrasi
Copy link
Author

@swift-ci please test tensorflow linux gpu

@marcrasi
Copy link
Author

@swift-ci please test tensorflow

2 similar comments
@marcrasi
Copy link
Author

@swift-ci please test tensorflow

@marcrasi
Copy link
Author

@swift-ci please test tensorflow

@marcrasi
Copy link
Author

@swift-ci please test tensorflow linux

@marcrasi marcrasi merged commit a0a7ee5 into swiftlang:tensorflow Dec 11, 2018
@marcrasi marcrasi deleted the unique-ad-structures branch December 11, 2018 22:23
rxwei added a commit that referenced this pull request Dec 12, 2018
@rxwei
Revert "uniquely allocate AutoDiffParameterIndices and AutoDiffAssoci…
6d4893a 
…atedFunctionIdentifier (#21193)"

This reverts commit a0a7ee5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxwei rxwei rxwei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcrasi @rxwei