Skip to content

[5.0] [String] UTF8View.withContiguousStorageIfAvailable #21194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2018
Merged

[5.0] [String] UTF8View.withContiguousStorageIfAvailable #21194

merged 2 commits into from
Dec 13, 2018

Conversation

milseman
Copy link
Member

@milseman milseman commented Dec 10, 2018 •
edited
Loading

5.0 cherry-pick of #21178

rdar://problem/34598630

@milseman milseman requested a review from a team as a code owner December 10, 2018 23:59
@milseman
Copy link
Member Author

@swift-ci please test

airspeedswift
airspeedswift approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@airspeedswift airspeedswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but are you going to add tests too?

@milseman
Copy link
Member Author

milseman commented Dec 11, 2018 •
edited
Loading

Definitely, I'm working on that now. I don't know if there are impending cutoffs; feel free to await those.

@milseman milseman changed the title [String] UTF8View implements withContiguousStorageIfAvailable [5.] [String] UTF8View implements withContiguousStorageIfAvailable Dec 12, 2018
@milseman milseman changed the title [5.] [String] UTF8View implements withContiguousStorageIfAvailable [5.] [String] UTF8View.withContiguousStorageIfAvailable Dec 12, 2018
@milseman milseman changed the title [5.] [String] UTF8View.withContiguousStorageIfAvailable [5.0] [String] UTF8View.withContiguousStorageIfAvailable Dec 12, 2018
@milseman
Copy link
Member Author

@airspeedswift pushed the tests to this branch too

@milseman
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 7f30103

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 7f30103

@airspeedswift airspeedswift merged commit 050c1db into swiftlang:swift-5.0-branch Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airspeedswift airspeedswift airspeedswift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milseman @swift-ci @airspeedswift