Skip to content

Fix ProtocolConformanceAnalysis for extensions #21195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2019
Merged

Fix ProtocolConformanceAnalysis for extensions #21195

merged 1 commit into from
Jan 4, 2019

Conversation

rajbarik
Copy link
Contributor

@rajbarik
Copy link
Contributor Author

@slavapestov @gottesmm Here is the PR.

@gottesmm
Copy link
Contributor

Can you also add the miscompile as an interpreter test that makes sure we emit the right string?

@rajbarik rajbarik requested a review from slavapestov December 11, 2018 01:12
@rajbarik
Copy link
Contributor Author

@gottesmm have a look.

@gottesmm
Copy link
Contributor

LGTM. Thanks for including the test case!

@rajbarik rajbarik requested a review from gottesmm December 11, 2018 16:50
@rajbarik
Copy link
Contributor Author

Can we push this forward? @slavapestov @gottesmm

slavapestov
slavapestov reviewed Dec 11, 2018
View reviewed changes
@rajbarik
Copy link
Contributor Author

done @slavapestov @gottesmm

slavapestov
slavapestov approved these changes Dec 13, 2018
View reviewed changes
@rajbarik
Copy link
Contributor Author

Ready?

@rajbarik
Copy link
Contributor Author

@slavapestov @gottesmm anything else?

@slavapestov
Copy link
Contributor

@swift-ci Please test

@slavapestov
Copy link
Contributor

@swift-ci Please test source compatibility

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 9053d047930ba7be69b4400fec872796e30171f2

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 9053d047930ba7be69b4400fec872796e30171f2

@rajbarik
Copy link
Contributor Author

@gottesmm @slavapestov please run tests here. My mistake, the earlier one had a problem in the test checking.

@atrick
Copy link
Contributor

atrick commented Dec 17, 2018

@swift-ci test.

@atrick
Copy link
Contributor

atrick commented Dec 17, 2018

@swift-ci test source compatibility.

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 019d95f5217e72880e5b9d3ee6e0968952bd9913

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 019d95f5217e72880e5b9d3ee6e0968952bd9913

@rajbarik
Copy link
Contributor Author

rajbarik commented Jan 3, 2019

@atrick can you run smoke test here? Thanks.

@atrick
Copy link
Contributor

atrick commented Jan 3, 2019

@swift-ci smoke test.

@rajbarik rajbarik merged commit 468dfa7 into swiftlang:master Jan 4, 2019
@swift-ci swift-ci mentioned this pull request Dec 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov approved these changes

@gottesmm gottesmm Awaiting requested review from gottesmm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rajbarik @gottesmm @slavapestov @swift-ci @atrick