Allow compiling against slightly different tensorflow directory layouts. #21199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test tensorflow |
mhong
approved these changes
Dec 11, 2018
|
@swift-ci please test tensorflow |
1 similar comment
|
@swift-ci please test tensorflow |
|
I'll ask cmake expert @dan-zheng to take a look at this. |
|
Wait, did I just mis-press the "Revert" button? Sorry! |
|
Looks like it was not pressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks to see if the directory layout of --tensorflow-host-include-dir is
third_party/tensorflow/... and then adjusts all the paths accordingly. When building against normal tensorflow, everything should work normally.