Fix order-dependent tests #21202
Merged
Fix order-dependent tests #21202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several tests only work when standard library declarations are listed in a certain order. This change weakens those tests enough to tolerate ordering changes.
|
@swift-ci please smoke test |
DougGregor
approved these changes
Dec 11, 2018
|
@swift-ci please smoke test linux platform |
|
Linux failure is in Foundation tests and this only changes our own test suite, so it's hard to see how they could be related. |
|
Nice, this is something that I am hitting with a number of tests with the SIL Serialization during the Windows bring up. Perhaps we should always use |
|
@gottesmm had some opinions on the use of |
|
The problem with -emit-sorted-sil is that it is often times not needed and hides any problems around non-determinism in the compiler. |
|
Feel free to keep discussing sorted output, but I think we want this test change regardless, so I'm going to merge this and move on to the next thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve discovered several tests which break when standard library declarations are shuffled because the order of witnesses in SIL witnesss tables changes. As far as I can tell, these failures don’t actually indicate anything has broken; the tests are just too strict. This change loosens those tests a bit so they will pass no matter how we arrange declarations in the standard library.