[ConstraintSystem] Erase InOutExpr from member base
#21203
Merged
+41
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diagnostics could introduce type-checked expressions into AST during it's bottom up re-typechecking in attempt to find a problem. To minimize number of AST permutations solver has to handle let's just strip away implicit `InOutExpr` introduced by previous successful type-checks, which is not really important anyway. Resolves: rdar://problem/46459603
|
Couldn't re-open previously closed PR for some reason. @slavapestov Removing |
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
/cc @nathawes forgot to ping you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diagnostics could introduce type-checked expressions into AST during
it's bottom up re-typechecking in attempt to find a problem.
To minimize number of AST permutations solver has to handle
let's just strip away implicit
InOutExprintroduced by previoussuccessful type-checks, which is not really important anyway.
Resolves: rdar://problem/46459603