[AutoDiff] Simplify function type differentiability to be binary #21211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rxwei
commented
Dec 11, 2018
rxwei
commented
- No longer make the distinction between forward, reverse, etc as they are no longer needed in the updated design.
- Remove a bunch of stale code.
* No longer make the distinction between forward, reverse, etc.
|
@swift-ci please test tensorflow |
marcrasi
approved these changes
Dec 11, 2018
…rentiability # Conflicts: # include/swift/AST/AutoDiff.h # lib/AST/Builtins.cpp
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.