[5.0] KeyPath: Allow existing context descriptors to be used as generic environment. #21214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
Oops, this will merge conflict with #21213, so I'll wait to update till that's merged. |
…ironment. If a key path literal appears in a generic context with an existing context descriptor, this will allow us to save some code size by not having to emit a separate GenericEnvironment descriptor.
jckarter
force-pushed
the
key-path-generic-environment-or-context-5.0
branch
from
0df51fa to
df523d4
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
AnnaZaks
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a key path literal appears in a generic context with an existing context descriptor, this will allow us to
save some code size by not having to emit a separate GenericEnvironment descriptor. rdar://problem/46633593
This is an additive ABI change. It is not necessary for convergence.