Split subclasses out of ArchetypeType. #21244
Conversation
|
@swift-ci Please test |
include/swift/AST/TypeNodes.def
Outdated
| @@ -131,9 +131,13 @@ ABSTRACT_TYPE(AnyMetatype, Type) | |||
| ALWAYS_CANONICAL_TYPE(Module, Type) | |||
| TYPE(DynamicSelf, Type) | |||
| ABSTRACT_TYPE(Substitutable, Type) | |||
| ALWAYS_CANONICAL_TYPE(Archetype, SubstitutableType) | |||
| ABSTRACT_TYPE(Archetype, SubstitutableType) | |||
| ALWAYS_CANONICAL_TYPE(ContextArchetype, ArchetypeType) | |||
There was a problem hiding this comment.
I hate to make you rename everything but we've called these "primary archetypes" elsewhere
There was a problem hiding this comment.
No problem. I'll also rename ChildArchetype to NestedArchetype, which jives better with the terminology used elsewhere.
|
Build failed |
|
Build failed |
Context archetypes and opened existential archetypes differ in a number of details, and this simplifies the overlapping storage of the kind-specific fields. This should be NFC; for now, this doesn't change the interface of ArchetypeType, but should allow some refinements of how the special handling of certain archetypes are handled.
jckarter
force-pushed
the
archetype-subclasses
branch
from
f5e5982 to
f1648a1
Compare
|
Please test with following pull request: @swift-ci Please test |
|
@slavapestov How's this look now? |
|
Build failed |
|
Build failed |
Context archetypes and opened existential archetypes differ in a number of details, and this simplifies the overlapping storage of the kind-specific fields. This should be NFC; for now, this doesn't change the interface of ArchetypeType, but should allow some refinements of how the special handling of certain archetypes are handled.