AST: Rework @objcMembers inheritance to not depend on validation order [5.0] #21261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sema would directly check for the presence of the @objcMembers attribute, and inherit it from the immediate superclass in validateDecl(). We don't want validateDecl() to have side effects like this and this was already a problem, because it would not inherit the attribute transitively in some cases. Instead, add a ClassDecl::hasObjCMembers() method that walks over all ancestors and caches the result. <rdar://problem/46420252>
slavapestov
changed the title
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
line-sdk-ios is failing on the Swift 5.0 branch as well: https://ci.swift.org/view/Source%20Compatibility/job/swift-5.0-source-compat-suite/115/artifact/swift-source-compat-suite/ |
AnnaZaks
approved these changes
Dec 13, 2018
|
Source compat issue is unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sema would directly check for the presence of the @objcMembers attribute,
and inherit it from the immediate superclass in validateDecl().
We don't want validateDecl() to have side effects like this and this was
already a problem, because it would not inherit the attribute transitively
in some cases.
Instead, add a ClassDecl::hasObjCMembers() method that walks over all
ancestors and caches the result.
rdar://problem/46420252