Skip to content

[5.0] IRGen: Handle self-conformances in defineAssociatedTypeWitnessT… #21263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

aschwaighofer
Copy link
Contributor

…ableAccessFunction

  • No ABI impact
  • Fixes compiler crash

rdar://46664811

…ableAccessFunction

* No ABI impact
* Fixes compiler crash

rdar://46664811
@aschwaighofer aschwaighofer requested a review from a team as a code owner December 12, 2018 21:31
@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@slavapestov
Copy link
Contributor

Thanks! Can you file a radar to clean up the self-conformance representation so that we don't build abstract conformances that need explicit handling in this situation?

Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AnnaZaks AnnaZaks merged commit bdcc2ec into swiftlang:swift-5.0-branch Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants