Skip to content

test: invoke python scripts with the interpreter #21272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

compnerd
Copy link
Member

Ensure that we explicitly provide the path to the interpreter when
running the python scripts during the tests. This is needed to have the
tests work on Windows which does not honour the shebang in the file. It
also ensures that we use the correct interpreter for the tests.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

Ensure that we explicitly provide the path to the interpreter when
running the python scripts during the tests.  This is needed to have the
tests work on Windows which does not honour the shebang in the file.  It
also ensures that we use the correct interpreter for the tests.
@compnerd
Copy link
Member Author

CC: @graydon @jrose-apple

@compnerd
Copy link
Member Author

@swift-ci please test and merge

Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should mark all our test helper Python scripts as non-executable, maybe even removing the shebang lines, so we don't regress here.

@swift-ci swift-ci merged commit 0625081 into swiftlang:master Dec 13, 2018
@compnerd compnerd deleted the interpreter branch December 13, 2018 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants