Exclude/fix certain tests for swift-evolve #21276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a swift_evolve feature to our lit configuration and uses it to mark several tests as unsupported by swift_evolve. One of these—test/api-digester/stability-stdlib-abi.swift—is actually pretty bad; we would really like to have it. But the digester has known issues exposed by swift-evolve.
|
Tagging @nkcsgexi because he wrote a few of these tests and @jrose-apple because he suggested using a lit feature. |
|
@swift-ci please smoke test |
nkcsgexi
approved these changes
Dec 13, 2018
jrose-apple
reviewed
Dec 13, 2018
* Distinguish between tests which are intentionally unsupported and temporarily disabled. * Add an explanation for one unsupproted test. * Code nitpick.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a swift_evolve feature to our lit configuration and marks several tests as unsupported with it.
swift-evolve is a tool currently in development which automatically modifies source code in ways that should be source- and ABI-compatible; we will be using it to test resilience. Currently it simply shuffles declarations. The tests I'm marking as unsupported in this pull request either intentionally depend on the order of declarations, or expose bugs in our tools that we've filed but haven't fixed.
This PR also fixes one more order-dependent test in SourceKit.
Part of rdar://problem/44426013.