[5.0] [Constraint solver] De-prioritize SIMD operators. #21280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new SIMD proposal introduced a number of new operators, the presence of which causes more "expression too complex" failures. Route around the problem by de-prioritizing those operators, visiting them only if no other operator could be chosen. This should limit the type checker performance cost of said operators to only those expressions that need them OR that already failed to type-check. Fixes rdar://problem/46541800. (cherry picked from commit 88d34a1)
(cherry picked from commit 052d4c1)
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
Those source-compatibility failures are for the newly-added "line" project, which was triggering an assertion. |
AnnaZaks
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new SIMD proposal introduced a number of new operators, the presence of
which causes more "expression too complex" failures. Route around the
problem by de-prioritizing those operators, visiting them only if no
other operator could be chosen. This should limit the type checker
performance cost of said operators to only those expressions that need
them OR that already failed to type-check.
Fixes rdar://problem/46541800.