[WIP][Sema][stdlib] Remove _getBuiltinLogicValue #21285
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update api-digester add implicit comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
_getBuiltinLogicValue()intrinsic function fromBooland instead accesses theBool._valueproperty directly. Currently the property is internal, but I noticed that the integer and floating point types backing value is public, so I thought it might be better to access the property than keep this function in the stdlib API.I labeled this WIP because there are at least 5 known tests failing that I can't seem to reason about:
SILGen/opaque_ownership.swiftrefactoring/CollaseNestedIfrefactoring/ConvertToTernaryExprrefactoring/ExpandTernaryExprstmt/statements.swiftOne thing I've noticed in the bottom 4 is that any boolean stmt condition is cutting off the last expression in refactoring/fixits. E.g. instead of
where 1 != 100, the fixit suggests:where 1 !=. Which is slightly confusing as my change doesn't touch refactoring/fixits. 😕cc: @slavapestov and some standard library folk: @airspeedswift